Skip to content

Conversation

@jperals
Copy link
Member

@jperals jperals commented Nov 4, 2025

Description

Moving these tests out of the demos, because handling screen resize is a responsibility of the board components library and not of the consumers' board implementation, and also because these tests are causing flakiness (AWSUI-61284).

Related links, issue #, if available: AWSUI-61284

How has this been tested?

Ran the new tests locally.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (219c285) to head (4661d53).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #381   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          67       67           
  Lines        3278     3278           
  Branches      702      702           
=======================================
  Hits         3118     3118           
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals marked this pull request as ready for review November 4, 2025 08:54
@jperals jperals requested a review from a team as a code owner November 4, 2025 08:54
@jperals jperals requested review from pan-kot and removed request for a team November 4, 2025 08:54
@jperals jperals added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 3857e43 Nov 4, 2025
47 of 49 checks passed
@jperals jperals deleted the chore/coverage-screen-resize branch November 4, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants