chore: avoid re-rendering tooltips on each cursor pixel change over charts #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enmanuelduran
force-pushed
the
tooltip-performance-improvement-on-render
branch
from
081b31e to
b6187ed
Compare
pan-kot
reviewed
Aug 8, 2025
| // Just re-render when the groups are different. | ||
| private setGroupIfDifferent(group: readonly Highcharts.Point[]) { | ||
| function isGroupEqual(a: Highcharts.Point, b: Highcharts.Point) { | ||
| return a?.x === b?.x && a?.y === b?.y && a?.series?.type === b?.series?.type; |
Member
There was a problem hiding this comment.
The series often have the same type, but those can be different series. I suggest we compare them as such: getSeriesId(a?.series) === getSeriesId(b?.series).
pan-kot
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Significantly reduces the amount of re-renders on data point tooltips by implementing group deep equality check -- groups change depending on the cursor position on the chart and the proximity of the datapoints to the cursor, at the moment it is not necessary to re-render the tooltip when we know we are still on the same group domain.
Using react dev tools to analyze the cadence of the render events
Before
After
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.