Skip to content

Conversation

@cansuaa
Copy link
Member

@cansuaa cansuaa commented Nov 18, 2024

Description

Fix chat bubble test name and get design token update to propagate in chat components

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cansuaa cansuaa requested a review from a team as a code owner November 18, 2024 12:11
@cansuaa cansuaa requested review from YueyingLu and pan-kot and removed request for a team and YueyingLu November 18, 2024 12:11
@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (316e93b) to head (7213b59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          19       19           
  Lines         520      520           
  Branches       34       34           
=======================================
  Hits          516      516           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cansuaa cansuaa added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit ac996e0 Nov 18, 2024
38 of 39 checks passed
@cansuaa cansuaa deleted the cansua/chat-bubble-design-token-propagation branch November 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants