Skip to content

Conversation

@just-boris
Copy link
Member

@just-boris just-boris commented Sep 10, 2025

Description

Unblock this change: #89

TooltipWrapper is an empty class we can replace it with ElementWrapper to simplify dependencies

https://github.com/cloudscape-design/components/blob/3b136937f369cec711df914e867d99992ff8372c/src/test-utils/dom/internal/tooltip.ts#L7-L9

How has this been tested?

Test-util change only, PR build is enough

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (0c6e055) to head (92bbe45).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          29       29           
  Lines         679      679           
  Branches      114      114           
=======================================
  Hits          653      653           
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris marked this pull request as ready for review September 10, 2025 14:23
@just-boris just-boris requested a review from a team as a code owner September 10, 2025 14:23
@just-boris just-boris requested review from YueyingLu and removed request for a team September 10, 2025 14:23
@just-boris just-boris added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit b0f0eff Sep 11, 2025
39 of 40 checks passed
@just-boris just-boris deleted the remove-tooltip-wrapper branch September 11, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants