Skip to content

Conversation

@fralongo
Copy link
Member

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@fralongo fralongo requested a review from a team as a code owner July 15, 2025 10:04
@fralongo fralongo requested review from abdhalees and removed request for a team July 15, 2025 10:04
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (9cb7d0e) to head (337ccc8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files          33       33           
  Lines         826      826           
  Branches      232      222   -10     
=======================================
  Hits          821      821           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}
}

describe('getComponentsTree', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just do describe.skip? and keep all the files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is already covered by unit tests, the only reason to have the integration tests is that they were written first but they did not count for coverage.

On the other hand, I think the TypeScript compatibility issue can alternatively be fixed by just reverting the change in src/internal/analytics-metadata/index.ts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately without the type the test pages do not build correctly. I will explore better options to add those tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to unblock other releases.

@abdhalees abdhalees self-requested a review July 15, 2025 10:42
@georgylobko georgylobko added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit 1474b56 Jul 15, 2025
36 checks passed
@georgylobko georgylobko deleted the flongo-fix-build branch July 15, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants