Skip to content

Conversation

@jperals
Copy link
Member

@jperals jperals commented Sep 30, 2025

Description

API proposal: 3K5dAAa8Le31

How has this been tested?

With visual regression tests (CR-235704718)

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (abb494e) to head (8d7a83b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3906   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         861      861           
  Lines       25207    25210    +3     
  Branches     9098     9100    +2     
=======================================
+ Hits        24450    24453    +3     
- Misses        710      751   +41     
+ Partials       47        6   -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals force-pushed the feat/horizontal-radio-group branch from c21b56c to b0e4da6 Compare September 30, 2025 14:30
@jperals jperals force-pushed the feat/horizontal-radio-group branch from 94c388d to 76771bf Compare November 3, 2025 07:43
@jperals jperals force-pushed the feat/horizontal-radio-group branch from d8cbadc to 6ac9077 Compare November 7, 2025 15:12
@jperals jperals force-pushed the feat/horizontal-radio-group branch from 6ac9077 to ddd2ff5 Compare November 13, 2025 17:25
@jperals jperals marked this pull request as ready for review November 17, 2025 15:39
@jperals jperals requested a review from a team as a code owner November 17, 2025 15:39
@jperals jperals requested review from taheramr and removed request for a team November 17, 2025 15:39
@jperals jperals force-pushed the feat/horizontal-radio-group branch from a0b463b to e9700a8 Compare November 18, 2025 21:53
@jperals jperals force-pushed the feat/horizontal-radio-group branch from e9700a8 to 8d7a83b Compare November 18, 2025 21:58
@jperals jperals changed the title feat: Horizontal radio group feat: Add horizontal direction to radio group Nov 19, 2025
),
},
{
value: 'forth',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested by AI to be fourth which is correct but this is not blocking at all :D, approving since no other issues found

@jperals jperals added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit b48eddd Nov 19, 2025
50 checks passed
@jperals jperals deleted the feat/horizontal-radio-group branch November 19, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants