-
Notifications
You must be signed in to change notification settings - Fork 204
feat: Add horizontal direction to radio group #3906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3906 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 861 861
Lines 25207 25210 +3
Branches 9098 9100 +2
=======================================
+ Hits 24450 24453 +3
- Misses 710 751 +41
+ Partials 47 6 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c21b56c to
b0e4da6
Compare
94c388d to
76771bf
Compare
d8cbadc to
6ac9077
Compare
6ac9077 to
ddd2ff5
Compare
a0b463b to
e9700a8
Compare
e9700a8 to
8d7a83b
Compare
| ), | ||
| }, | ||
| { | ||
| value: 'forth', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested by AI to be fourth which is correct but this is not blocking at all :D, approving since no other issues found
Description
API proposal:
3K5dAAa8Le31How has this been tested?
With visual regression tests (
CR-235704718)Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.