Skip to content

Conversation

@karmanya79
Copy link
Contributor

@karmanya79 karmanya79 commented Nov 30, 2022

Description

Top navigation menudropdown now has corect heading markup rather than using span

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 92.40% // Head: 92.40% // No change to project coverage 👍

Coverage data is based on head (6ac84b8) compared to base (83c1c9b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         571      571           
  Lines       16218    16218           
  Branches     4443     4443           
=======================================
  Hits        14986    14986           
  Misses       1149     1149           
  Partials       83       83           
Impacted Files Coverage Δ
src/button-dropdown/internal.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@karmanya79 karmanya79 marked this pull request as ready for review November 30, 2022 17:25
@karmanya79 karmanya79 requested a review from a team as a code owner November 30, 2022 17:25
@karmanya79 karmanya79 requested review from abdhalees and avinashbot and removed request for a team November 30, 2022 17:25
@karmanya79 karmanya79 requested a review from abdhalees December 2, 2022 19:07
@avinashbot avinashbot merged commit d708896 into cloudscape-design:main Dec 5, 2022
@avinashbot avinashbot changed the title fix: Top-Navigation Menu dropdown heading using correct markup fix: Use semantic heading inside top navigation menu dropdown title Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants