Skip to content

Conversation

@Al-Dani
Copy link
Member

@Al-Dani Al-Dani commented Jan 13, 2023

Description

Correct heading level provided for the menu dropdown in TopNavigation

Follow-up for #539

Related links, issue #, if available:AWSUI-19250

How has this been tested?

Manually

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Al-Dani Al-Dani requested a review from avinashbot January 13, 2023 16:32
@Al-Dani Al-Dani requested a review from a team as a code owner January 13, 2023 16:32
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 92.98% // Head: 92.98% // No change to project coverage 👍

Coverage data is based on head (26abe8b) compared to base (5fced58).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         574      574           
  Lines       16753    16753           
  Branches     4620     4620           
=======================================
  Hits        15577    15577           
  Misses       1099     1099           
  Partials       77       77           
Impacted Files Coverage Δ
src/button-dropdown/internal.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Al-Dani Al-Dani merged commit ea7bf71 into main Jan 13, 2023
@Al-Dani Al-Dani deleted the topnav-header-tag-fix branch January 13, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants