Skip to content

Conversation

@Al-Dani
Copy link
Member

@Al-Dani Al-Dani commented Dec 5, 2022

Description

Additional dynamic-aria-live helper component is used to announce progress bar status in progress. Screenreader makes announcement not more often than specified interval. For progress updates this interval is set to 5 second to reduce noise with a small update granularity.

Related links, issue #, if available: AWSUI-19156

How has this been tested?

Manually, using screenreader. New Integration test is also presented.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Al-Dani Al-Dani requested a review from a team as a code owner December 5, 2022 08:09
@Al-Dani Al-Dani requested review from taheramr and removed request for a team December 5, 2022 08:09
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 92.40% // Head: 92.50% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (4bf7eca) compared to base (d708896).
Patch coverage: 93.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
+ Coverage   92.40%   92.50%   +0.09%     
==========================================
  Files         571      574       +3     
  Lines       16218    16351     +133     
  Branches     4443     4484      +41     
==========================================
+ Hits        14986    15125     +139     
+ Misses       1149     1145       -4     
+ Partials       83       81       -2     
Impacted Files Coverage Δ
src/progress-bar/internal.tsx 95.45% <ø> (ø)
src/internal/components/live-region/index.tsx 83.33% <66.66%> (-4.17%) ⬇️
src/internal/components/live-region/utils.ts 87.50% <87.50%> (ø)
...rc/internal/components/dynamic-aria-live/index.tsx 100.00% <100.00%> (ø)
.../internal/components/live-region/aria-liva-tag.tsx 100.00% <100.00%> (ø)
src/progress-bar/index.tsx 100.00% <100.00%> (ø)
src/mixed-line-bar-chart/chart-container.tsx 85.78% <0.00%> (-4.72%) ⬇️
src/mixed-line-bar-chart/internal.tsx 91.00% <0.00%> (-3.00%) ⬇️
src/internal/styles/colors.ts 100.00% <0.00%> (ø)
src/table/body-cell/index.tsx 100.00% <0.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Al-Dani Al-Dani requested review from a team and abdhalees and removed request for a team and taheramr December 5, 2022 15:53
@Al-Dani Al-Dani force-pushed the announce-progress-bar branch from afeec06 to 89baacc Compare December 8, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants