-
Notifications
You must be signed in to change notification settings - Fork 204
feat: Progress bar updates are announced to the user #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 92.40% // Head: 92.50% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
+ Coverage 92.40% 92.50% +0.09%
==========================================
Files 571 574 +3
Lines 16218 16351 +133
Branches 4443 4484 +41
==========================================
+ Hits 14986 15125 +139
+ Misses 1149 1145 -4
+ Partials 83 81 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
afeec06 to
89baacc
Compare
Description
Additional dynamic-aria-live helper component is used to announce progress bar status in progress. Screenreader makes announcement not more often than specified interval. For progress updates this interval is set to 5 second to reduce noise with a small update granularity.
Related links, issue #, if available: AWSUI-19156
How has this been tested?
Manually, using screenreader. New Integration test is also presented.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.