Skip to content

Conversation

@Al-Dani
Copy link
Member

@Al-Dani Al-Dani commented Jan 6, 2023

Description

Remove dynamic aria live component and restore initial live region component structure.
Use live region component in progress bar directly.

Follow-up for #555

How has this been tested?

Manually with screen reader.
New unit test added

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 92.83% // Head: 92.84% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bb9df9c) compared to base (9476ae4).
Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage   92.83%   92.84%           
=======================================
  Files         572      569    -3     
  Lines       16476    16466   -10     
  Branches     4530     4527    -3     
=======================================
- Hits        15296    15288    -8     
+ Misses       1104     1102    -2     
  Partials       76       76           
Impacted Files Coverage Δ
src/internal/components/live-region/index.tsx 95.83% <93.33%> (+12.50%) ⬆️
src/progress-bar/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Al-Dani Al-Dani requested a review from pan-kot January 9, 2023 07:40
@Al-Dani Al-Dani marked this pull request as ready for review January 9, 2023 07:41
@Al-Dani Al-Dani requested a review from a team as a code owner January 9, 2023 07:41
@Al-Dani Al-Dani merged commit c1b2222 into main Jan 9, 2023
@Al-Dani Al-Dani deleted the live-region-refactor branch January 9, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants