feat: Add ariaControls prop to RadioGroup #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa7ad
force-pushed
the
feat/progressive-disclosure
branch
2 times, most recently
from
c58a3e7 to
80516a9
Compare
fa7ad
force-pushed
the
feat/progressive-disclosure
branch
from
80516a9 to
6c9784e
Compare
fa7ad
changed the title
Codecov ReportBase: 92.98% // Head: 92.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 574 574
Lines 16782 16783 +1
Branches 4632 4632
=======================================
+ Hits 15604 15605 +1
Misses 1101 1101
Partials 77 77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fa7ad
force-pushed
the
feat/progressive-disclosure
branch
2 times, most recently
from
cf78290 to
e90d8dc
Compare
fa7ad
force-pushed
the
feat/progressive-disclosure
branch
2 times, most recently
from
a8ed001 to
612efe6
Compare
just-boris
previously approved these changes
Jan 25, 2023
fa7ad
force-pushed
the
feat/progressive-disclosure
branch
from
612efe6 to
518bcd9
Compare
just-boris
previously approved these changes
Jan 25, 2023
fa7ad
force-pushed
the
feat/progressive-disclosure
branch
from
518bcd9 to
36e4e34
Compare
fa7ad
force-pushed
the
feat/progressive-disclosure
branch
from
36e4e34 to
4cc79e6
Compare
just-boris
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
ariaControlsprop to RadioGroup component.This should allow users to implement a progressive disclosure pattern AND make it accessible.
NOTE: The API documentation needs to reviewed and potentially changed; hold off on merging just yet.approvedRelated links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.