Skip to content

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented May 8, 2023

Description

Added aria-controls to Checkbox, Tiles and Toggle component APIs. The same has been previously added to the RadioGroup (see #659).

How has this been tested?

Added unit tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner May 8, 2023 15:54
@pan-kot pan-kot requested review from just-boris and timogasda and removed request for a team May 8, 2023 15:54
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dc96449) 92.81% compared to head (82e9280) 92.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files         606      606           
  Lines       15914    15915    +1     
  Branches     5135     5135           
=======================================
+ Hits        14771    14772    +1     
  Misses       1065     1065           
  Partials       78       78           
Impacted Files Coverage Δ
src/checkbox/internal.tsx 100.00% <ø> (ø)
src/toggle/internal.tsx 100.00% <ø> (ø)
src/internal/components/abstract-switch/index.tsx 100.00% <100.00%> (ø)
src/tiles/internal.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pan-kot pan-kot merged commit a03498f into main May 10, 2023
@pan-kot pan-kot deleted the aria-controls-for-toggle-checkbox-tiles branch May 10, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants