Skip to content

Conversation

@just-boris
Copy link
Member

Description

The linked PR cloudscape-design/component-toolkit#118 is released now, the tests pass without the workaround

Related links, issue #, if available: n/a

How has this been tested?

test-only change

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (7c8f26d) to head (6f0ee46).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3280   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         791      791           
  Lines       22574    22574           
  Branches     7735     7735           
=======================================
  Hits        21766    21766           
  Misses        754      754           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review February 11, 2025 20:05
@just-boris just-boris requested a review from a team as a code owner February 11, 2025 20:05
@just-boris just-boris requested review from Al-Dani and removed request for a team February 11, 2025 20:05
@just-boris just-boris added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 500ee9b Feb 12, 2025
38 checks passed
@just-boris just-boris deleted the app-layout-tests-remove-mocks branch February 12, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants