Skip to content

fix: set header bg to transparent if root bg is provided#4029

Merged
mxschll merged 2 commits intomainfrom
dev-v3-schomax-AWSUI-61442
Dec 5, 2025
Merged

fix: set header bg to transparent if root bg is provided#4029
mxschll merged 2 commits intomainfrom
dev-v3-schomax-AWSUI-61442

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Nov 11, 2025

Description

Changes done:

  • Fix for AWSUI-61442
  • Introduces unit tests

Related links, issue #, if available: n/a

How has this been tested?

Visual regression test.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (83500f3) to head (4dd986c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4029      +/-   ##
==========================================
- Coverage   97.12%   97.12%   -0.01%     
==========================================
  Files         864      864              
  Lines       25330    25326       -4     
  Branches     9139     9139              
==========================================
- Hits        24602    24598       -4     
  Misses        722      722              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll force-pushed the dev-v3-schomax-AWSUI-61442 branch from 4eaf909 to 754a5ed Compare November 11, 2025 21:17
@mxschll mxschll force-pushed the dev-v3-schomax-AWSUI-61442 branch from 754a5ed to 93fba53 Compare November 11, 2025 21:39
@mxschll mxschll force-pushed the dev-v3-schomax-AWSUI-61442 branch from 1130ac3 to 9324e6a Compare November 11, 2025 22:16
@mxschll mxschll force-pushed the dev-v3-schomax-AWSUI-61442 branch from 4ae9b89 to 6fc9dbd Compare November 13, 2025 11:26
@mxschll mxschll force-pushed the dev-v3-schomax-AWSUI-61442 branch from 6fc9dbd to 68f13bf Compare December 1, 2025 11:35
@mxschll mxschll force-pushed the dev-v3-schomax-AWSUI-61442 branch from 68f13bf to ff55f5e Compare December 5, 2025 11:52
@mxschll mxschll requested a review from Who-is-PS December 5, 2025 11:53
@mxschll mxschll changed the title fix: closes AWSUI-61442 fix: set header bg to transparent if root bg is provided Dec 5, 2025
@mxschll mxschll added this pull request to the merge queue Dec 5, 2025
Merged via the queue into main with commit 129dcc5 Dec 5, 2025
51 checks passed
@mxschll mxschll deleted the dev-v3-schomax-AWSUI-61442 branch December 5, 2025 16:56
ngynmt pushed a commit to ngynmt/components that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants