Skip to content

fix: Restore legacy test util selectors for Radio Group #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

fix: Restore legacy test util selectors for Radio Group #4058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed47f80
fix: Restore legacy test util selectors for Radio Group
jperals Nov 20, 2025
07192f2
Remove .radio selector
jperals Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/__tests__/snapshot-tests/__snapshots__/test-utils-selectors.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,8 @@ exports[`test-utils selectors 1`] = `
"awsui_token-editor-token-remove-actions_1heb1",
],
"radio-group": [
"awsui_radio_1mabk",
"awsui_root_1mabk",
Copy link
Member Author

@jperals jperals Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the two classnames that were removed here: https://github.com/cloudscape-design/components/pull/4021/files#diff-ce8e8ee722d906e9038b89e1e23cddc59e5a144eab9f63e99751ddd309ce7fd2L517-L518

"awsui_root_1np5w",
],
"s3-resource-selector": [
Expand Down
1 change: 1 addition & 0 deletions src/radio-group/internal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const InternalRadioGroup = React.forwardRef(
className={clsx(
baseProps.className,
testUtilStyles.root,
styles.root,
styles['radio-group'],
direction === 'horizontal' && styles['horizontal-group']
)}
Expand Down
4 changes: 4 additions & 0 deletions src/radio-group/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
@use '../internal/styles' as styles;
@use '../internal/styles/tokens' as awsui;

.root {
/* used for backwards-compatibility with older versions of test-utils */
}

.radio-group {
@include styles.styles-reset;

Expand Down
6 changes: 5 additions & 1 deletion src/test-utils/dom/radio-group/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,17 @@ import { escapeSelector } from '@cloudscape-design/test-utils-core/utils';
import RadioButtonWrapper from '../radio-button';

import radioButtonStyles from '../../../internal/components/radio-button/test-classes/styles.selectors.js';
import legacyStyles from '../../../radio-group/styles.selectors.js';
import styles from '../../../radio-group/test-classes/styles.selectors.js';

export default class RadioGroupWrapper extends ComponentWrapper {
static rootSelector: string = styles.root;
static legacyRootSelector: string = legacyStyles.root;

findButtons(): Array<RadioButtonWrapper> {
return this.findAllByClassName(radioButtonStyles.root).map(r => new RadioButtonWrapper(r.getElement()));
return this.findAll(`:is(.${radioButtonStyles.root}, .${legacyStyles.radio})`).map(
Copy link
Member Author

@jperals jperals Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For finding the radio group with the old test utils, adding the static legacyRootSelector statement above is enough (related: cloudscape-design/test-utils#100), but in order to find the radio buttons inside the radio group, it is necessary to manually construct the selector here.

r => new RadioButtonWrapper(r.getElement())
);
}

findInputByValue(value: string): ElementWrapper<HTMLInputElement> | null {
Expand Down
Loading