Skip to content

chore: Fixes flaky flashbar test#4234

Merged
pan-kot merged 1 commit intomainfrom
chore-fix-flashbar-flaky-test
Feb 9, 2026
Merged

chore: Fixes flaky flashbar test#4234
pan-kot merged 1 commit intomainfrom
chore-fix-flashbar-flaky-test

Conversation

@pan-kot
Copy link
Member

@pan-kot pan-kot commented Feb 9, 2026

Description

The flashbar test is flaky and fails occasionally in GitHub actions. That seems to be related to the scrolling not being completed. The nature of the test allows to repeat the scrolling action and assertion until it completes w/o sacrificing coverage.

How has this been tested?

Tested by running the test over 100 times with GitHub actions - there was not a single retry.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner February 9, 2026 11:20
@pan-kot pan-kot requested review from ClaudioGSDB and removed request for a team February 9, 2026 11:20
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (62efe83) to head (e24bc64).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4234      +/-   ##
==========================================
+ Coverage   97.18%   97.19%   +0.01%     
==========================================
  Files         885      886       +1     
  Lines       25897    25996      +99     
  Branches     9362     9415      +53     
==========================================
+ Hits        25168    25267      +99     
  Misses        723      723              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit daecfb0 Feb 9, 2026
49 checks passed
@pan-kot pan-kot deleted the chore-fix-flashbar-flaky-test branch February 9, 2026 12:12
ngynmt pushed a commit to ngynmt/components that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants