fix: Fixes tables with infinite expandable rows#4235
Merged
Conversation
pan-kot
requested review from
Harsh-Anand-Singh
and removed request for
a team
pan-kot
commented
Feb 9, 2026
|
|
||
| if (visible) { | ||
| visibleItems.push(item); | ||
| children.forEach((child, index) => |
Member
Author
There was a problem hiding this comment.
In an earlier version it was necessary to traverse all items even those not expanded. Now it is not needed, and all existing tests still work when making this change.
jperals
previously approved these changes
Feb 9, 2026
| traverse( | ||
| child, | ||
| { level: detail.level + 1, setSize: children.length, posInSet: index + 1, parent: item }, | ||
| visible && expandedSet.has(item) |
Member
There was a problem hiding this comment.
Nitpick: visible is not needed here
pan-kot
force-pushed
the
fix-expandable-table-infinite-loop
branch
from
224f41a to
1ee5450
Compare
jperals
approved these changes
Feb 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4235 +/- ##
==========================================
- Coverage 97.19% 97.19% -0.01%
==========================================
Files 886 886
Lines 26005 26004 -1
Branches 9418 9418
==========================================
- Hits 25275 25274 -1
+ Misses 724 683 -41
- Partials 6 47 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ngynmt
pushed a commit
to ngynmt/components
that referenced
this pull request
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small fix that allows expandable rows to be infinite, which is useful in tests.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.