chore: Replace alert and flashbar styles with design tokens#4401
Merged
chore: Replace alert and flashbar styles with design tokens#4401
Conversation
at-susie
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4401 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 909 909
Lines 26638 26638
Branches 9615 9615
=======================================
Hits 25959 25959
Misses 673 673
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| themeable: true, | ||
| public: true, | ||
| }, | ||
| fontWeightNotificationHeader: { |
Member
There was a problem hiding this comment.
Why not create separate tokens for alert and flashbar? I think this would be especially confusing as until now no "-notification-" tokens are used in Alert, but they are used in other components such as badge
Member
Author
There was a problem hiding this comment.
I agree with that. I will create separate ones. Thanks for the feedback.
gethinwebster
previously approved these changes
Mar 31, 2026
gethinwebster
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces styles in alert and flashbar with design tokens.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.