Skip to content

chore: enable screenshot testing for skeleton components-examples page #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amanabiy merged 1 commit into from
May 22, 2026
+24 −31
Merged

chore: enable screenshot testing for skeleton components-examples page #4548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions pages/skeleton/components-examples.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ import List from '~components/list';
import Skeleton from '~components/skeleton';
import SpaceBetween from '~components/space-between';

import { SimplePage } from '../app/templates';

interface DataItem {
id: string;
name: string;
Expand Down Expand Up @@ -58,22 +60,16 @@ export default function SkeletonComponentsExamples() {
const [isLoading, setIsLoading] = useState(true);

return (
<Box padding="l">
<div style={{ position: 'sticky', top: 0, zIndex: 1000, marginBottom: '2em' }}>
<Container>
<SpaceBetween size="m">
<Header
variant="h1"
description="Demonstrates skeleton loading patterns across different components to minimize layout shift"
>
Skeleton Component Examples
</Header>
<Checkbox checked={isLoading} onChange={({ detail }) => setIsLoading(detail.checked)}>
Show loading state (Skeleton)
</Checkbox>
</SpaceBetween>
</Container>
</div>
<SimplePage
title="Skeleton Component Examples"
subtitle="Demonstrates skeleton loading patterns across different components to minimize layout shift"
settings={
<Checkbox checked={isLoading} onChange={({ detail }) => setIsLoading(detail.checked)}>
Show loading state (Skeleton)
</Checkbox>
}
screenshotArea={{ disableAnimations: true }}
>
<SpaceBetween size="l">
{/* Cards Example */}
<Container header={<Header variant="h2">Cards with Skeleton</Header>}>
Expand Down Expand Up @@ -333,6 +329,6 @@ export default function SkeletonComponentsExamples() {
</>
</Container>
</SpaceBetween>
</Box>
</SimplePage>
);
}
25 changes: 11 additions & 14 deletions pages/skeleton/permutations.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import React from 'react';

import Skeleton, { SkeletonProps } from '~components/skeleton';

import { SimplePage } from '../app/templates';
import createPermutations from '../utils/permutations';
import PermutationsView from '../utils/permutations-view';
import ScreenshotArea from '../utils/screenshot-area';

const permutations = createPermutations<SkeletonProps>([
// Test all variants with default display and reasonable width
Expand Down Expand Up @@ -46,18 +46,15 @@ const permutations = createPermutations<SkeletonProps>([

export default function SkeletonPermutations() {
return (
<>
<h1>Skeleton permutations</h1>
<ScreenshotArea disableAnimations={true}>
<PermutationsView
permutations={permutations}
render={permutation => (
<div style={{ marginBottom: '16px' }}>
<Skeleton {...permutation} />
</div>
)}
/>
</ScreenshotArea>
</>
<SimplePage title="Skeleton permutations" screenshotArea={{ disableAnimations: true }}>
<PermutationsView
permutations={permutations}
render={permutation => (
<div style={{ marginBottom: '16px' }}>
<Skeleton {...permutation} />
</div>
)}
/>
</SimplePage>
);
}
Loading