Skip to content

fix: Prevent empty table from flickering #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2022
Merged

fix: Prevent empty table from flickering #542

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df31914
fix: Prevent empty table from flickering
abdhalees Dec 1, 2022
5d1fb7c
Merge branch 'main' into empty-table-flickering
abdhalees Dec 1, 2022
cc4a500
Merge branch 'main' into empty-table-flickering
abdhalees Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/table/use-sticky-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ export const useStickyHeader = (
}, [theadRef, secondaryTheadRef, secondaryTableRef, tableWrapperRef, tableRef]);
useLayoutEffect(() => {
syncColumnHeaderWidths();
// Content is not going to be layed out until the next frame in angular,
// so we need to sync the column headers again.
setTimeout(() => syncColumnHeaderWidths(), 0);
const secondaryTable = secondaryTableRef.current;
const primaryTable = tableWrapperRef.current;
return () => {
Expand All @@ -60,7 +57,7 @@ export const useStickyHeader = (
primaryTable.style.marginTop = '';
}
};
});
}, [secondaryTableRef, tableWrapperRef, syncColumnHeaderWidths]);
useResizeObserver(theadRef, syncColumnHeaderWidths);
const scrollToTop = () => {
if (!isMobile && theadRef.current && secondaryTheadRef.current && tableWrapperRef.current) {
Expand Down