Skip to content

Conversation

@Al-Dani
Copy link
Member

@Al-Dani Al-Dani commented Dec 21, 2022

Description

Ensure that after clicking outside of a chart component, highlighted segment will be cleared.

Additionally fixes discrepancy between space and enter keys behaviour for Pie chart.
It will work similarly to other charts.

Area chart behaviour will be adjusted separately.

Related links, issue #, if available: AWSUI-19991

How has this been tested?

New integration tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Al-Dani Al-Dani requested a review from a team as a code owner December 21, 2022 08:38
@Al-Dani Al-Dani requested review from gethinwebster and removed request for a team December 21, 2022 08:38
gethinwebster
gethinwebster previously approved these changes Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 92.64% // Head: 92.73% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (bb27a4c) compared to base (a331cd8).
Patch coverage: 95.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   92.64%   92.73%   +0.09%     
==========================================
  Files         572      572              
  Lines       16447    16467      +20     
  Branches     4511     4525      +14     
==========================================
+ Hits        15237    15271      +34     
+ Misses       1133     1120      -13     
+ Partials       77       76       -1     
Impacted Files Coverage Δ
src/mixed-line-bar-chart/chart-container.tsx 86.97% <88.88%> (+1.12%) ⬆️
src/pie-chart/pie-chart.tsx 87.42% <100.00%> (+5.28%) ⬆️
src/table/use-sticky-header.ts 82.35% <0.00%> (-3.37%) ⬇️
src/table/body-cell/index.tsx 100.00% <0.00%> (ø)
src/table/internal.tsx 97.77% <0.00%> (+0.06%) ⬆️
src/table/thead.tsx 96.42% <0.00%> (+0.35%) ⬆️
src/container/internal.tsx 91.48% <0.00%> (+0.37%) ⬆️
src/internal/components/chart-popover/index.tsx 100.00% <0.00%> (+3.33%) ⬆️
src/pie-chart/segments.tsx 97.43% <0.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Al-Dani Al-Dani merged commit c5f6ca8 into main Dec 21, 2022
@Al-Dani Al-Dani deleted the chart-highlight-on-dismiss branch December 21, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants