Skip to content
This repository was archived by the owner on Oct 23, 2025. It is now read-only.

Conversation

@jtojnar
Copy link

@jtojnar jtojnar commented Sep 9, 2022

Passing --tags in extra argument does not work for version:latest for some reason so we need to do that in a separate step.

Fixes: #16

What's Changed

Incorporates fixes from #31 (but properly escaped) and #33 (without the CI change, since that requires credentials contributors won’t have).

Passing `--tags` in extra argument does not work for `version:latest`
for some reason so we need to do that in a separate step.
@jtojnar jtojnar requested a review from a team as a code owner September 9, 2022 17:45
@jtojnar jtojnar mentioned this pull request Sep 9, 2022
@DavidS-cloud
Copy link

Thanks for your quick follow-up here. I've created an internal ticket to review and merge this, as well as improve our testing here so we don't accidentally regress other functionality again.

@BartoszBlizniak
Copy link
Member

This has been implemented in latest version

@jtojnar
Copy link
Author

jtojnar commented Jun 4, 2024

Does it actually work with version:latest? The reason I had to implement the feature using a separate cloudsmith tags add command was because the --tags did not work properly with the virtual tag (as I discussed on 2022-05-11 with your support agent Ciara, selfoss does not use sequential versions so we have to set version:latest manually).

I guess there is/was some hook updating version:latest that triggers only after the package is pushed, so it clobbers the version:latest tag passed through --tags to push command.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Support for adding tags

3 participants