Skip to content
This repository was archived by the owner on Oct 23, 2025. It is now read-only.

Conversation

@BartoszBlizniak
Copy link
Member

What's Changed

Remove the need for JQ to be installed and use sed or awk instead to grab the latest release of the CLI. Some customers can't use 3rd party actions that are not verified, this PR should tackle this.

@BartoszBlizniak BartoszBlizniak requested a review from a team as a code owner June 19, 2024 12:35
@paddycarey
Copy link
Member

Does this work on MacOS runners? sed/awk may behave differently there

@BartoszBlizniak
Copy link
Member Author

BartoszBlizniak commented Jun 19, 2024

@paddycarey

Does this work on MacOS runners? sed/awk may behave differently there

That works on the MacOS runner but the actual entrypoint.sh doesn't: https://github.com/BartoszBlizniak/cloudsmith-githubactions-test/actions/runs/9582268941/job/26420875958#step:5:142

Not sure if we ever tested running the action on MacOS

@BartoszBlizniak
Copy link
Member Author

I'm going to merge this in to unblock a customer. I will create a CENG ticket to test MacOS runner, don't think we tested that when we switched to composite.

@BartoszBlizniak BartoszBlizniak merged commit cada5f3 into cloudsmith-io:master Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants