Skip to content

CENG-355: Add --show-all flag to display all results from repo/package list#172

Merged
BartoszBlizniak merged 31 commits intomasterfrom
ceng-355-httpsgithubcomcloudsmith-iocloudsmith-clipull171
Nov 7, 2025
Merged

CENG-355: Add --show-all flag to display all results from repo/package list#172
BartoszBlizniak merged 31 commits intomasterfrom
ceng-355-httpsgithubcomcloudsmith-iocloudsmith-clipull171

Conversation

@BartoszBlizniak
Copy link
Copy Markdown
Member

@BartoszBlizniak BartoszBlizniak commented Sep 25, 2024

This PR includes the suggestion/contribution from PR 171 (Issue 170)
Nov-05-2025 21-31-39

  • Added --show-all flag to all supported pagination elements (Repo, Package, Upstream, Policy)
  • Updated unit tests to reflect the change
  • Added slug_perm to documentation for dependency command for clarity

@BartoszBlizniak BartoszBlizniak force-pushed the ceng-355-httpsgithubcomcloudsmith-iocloudsmith-clipull171 branch from cf3ca3b to c79c929 Compare October 16, 2024 16:18
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit ce41ea2 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 8
Duplication 2

The test coverage on the diff in this pull request is 87.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.4% (1.1% change).

View more on Code Climate.

…71' of github.com:cloudsmith-io/cloudsmith-cli into ceng-355-httpsgithubcomcloudsmith-iocloudsmith-clipull171
Copilot AI review requested due to automatic review settings November 5, 2025 16:32
@BartoszBlizniak BartoszBlizniak requested a review from a team as a code owner November 5, 2025 16:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a --show-all flag to enable displaying all paginated results for repositories, packages, upstreams, and policies, addressing user requests to fetch complete result sets without manual pagination. The implementation includes validation to prevent conflicting usage with pagination flags, adds comprehensive test coverage, and includes minor documentation improvements.

Key changes:

  • Added --show-all flag with validation logic preventing concurrent use with --page or --page-size
  • Implemented paginate_results() utility function to automatically fetch all pages when flag is enabled
  • Updated output formatting to distinguish between paginated and complete result displays

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
cloudsmith_cli/cli/validators.py Added validator to prevent --show-all from being used with pagination flags
cloudsmith_cli/cli/utils.py Refactored list info printing and added paginate_results() function for automatic pagination
cloudsmith_cli/cli/decorators.py Reordered option decorators to add --show-all flag before pagination options
cloudsmith_cli/cli/commands/upstream.py Integrated --show-all flag into upstream list command
cloudsmith_cli/cli/commands/repos.py Added --show-all support and adjusted output formatting for repositories
cloudsmith_cli/cli/commands/list_.py Updated package list command to support --show-all flag
cloudsmith_cli/cli/commands/policy/vulnerability.py Added --show-all support for vulnerability policies
cloudsmith_cli/cli/commands/policy/license.py Added --show-all support for license policies
cloudsmith_cli/cli/commands/dependencies.py Enhanced documentation to clarify slug_perm parameter
cloudsmith_cli/cli/tests/commands/*.py Added test coverage for --show-all flag functionality and validation
CONTRIBUTING.md Removed extraneous blank line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

BartoszBlizniak and others added 2 commits November 5, 2025 20:33
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@paddycarey paddycarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BartoszBlizniak BartoszBlizniak merged commit a959a5c into master Nov 7, 2025
13 checks passed
@BartoszBlizniak BartoszBlizniak deleted the ceng-355-httpsgithubcomcloudsmith-iocloudsmith-clipull171 branch November 7, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants