Fix for auth workflow due to Click 8.3.0 issue#234
Merged
colinmoynes merged 8 commits intomasterfrom Nov 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compatibility issue with Click v8.3.0 and bumps the version to 1.9.1. The breaking change in Click v8.3.0 affected the conversion of Sentinel.UNSET values, which impacted the auth --token workflow.
Key Changes:
- Excluded Click v8.3.0 from dependencies to prevent breaking changes
- Fixed indentation bug in config loading logic
- Enhanced the zipapp push command with explicit naming and versioning
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Adds exclusion for Click v8.3.0 to prevent compatibility issues |
| cloudsmith_cli/data/VERSION | Bumps version from 1.9.0 to 1.9.1 |
| cloudsmith_cli/cli/config.py | Fixes indentation to ensure config loading only happens when path exists |
| CODEOWNERS | Adds initial CODEOWNERS file with engineering team ownership |
| CHANGELOG.md | Documents the Click v8.3.0 fix in version 1.9.1 |
| .github/workflows/release.yml | Adds explicit name and version parameters to zipapp push command |
| .bumpversion.cfg | Updates current version to 1.9.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paddycarey
reviewed
Nov 5, 2025
paddycarey
reviewed
Nov 5, 2025
paddycarey
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a fix for the Click 8.3.0 issue, which was impacting the
cloudsmith auth-- tokenworkflow. This restricts to >=8.2.0 and !=8.3.0.It also includes an update to the actions workflow to help with an issue with zipapp package names.