Skip to content

feat: rename --show-all to --page-all and support it in page-size#238

Merged
BartoszBlizniak merged 8 commits intomasterfrom
ceng-605-update-show-all-to-page-all
Dec 16, 2025
Merged

feat: rename --show-all to --page-all and support it in page-size#238
BartoszBlizniak merged 8 commits intomasterfrom
ceng-605-update-show-all-to-page-all

Conversation

@BartoszBlizniak
Copy link
Copy Markdown
Member

@BartoszBlizniak BartoszBlizniak commented Nov 20, 2025

This PR changes occurrences of --show-all flag to --page-all, renaming internal references and tests to reflect this change. This change was introduced in response to internal feedback to maintain consistency in the language used in commands across the pagination features.

--show-all command is now an alias for --page-all to ensure backward compatability from previous release.


This change also introduces the possibility to pass either -1 or * (which will convert it to -1 behind the scenes) to --page-size (or its shortcut -l).

page-all

Copilot AI review requested due to automatic review settings November 20, 2025 09:36
@BartoszBlizniak BartoszBlizniak requested a review from a team as a code owner November 20, 2025 09:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the --show-all flag to --page-all (keeping --show-all as a deprecated alias for backwards compatibility) and introduces support for using -1 or * as values for --page-size to enable "show all results" behavior. The version is bumped from 1.9.4 to 1.9.5.

  • Parameter and function signature updates across all affected modules (pagination, validators, commands, utilities)
  • New IntOrWildcard custom Click type to accept integers or * wildcard (converted to -1)
  • Enhanced validation logic to handle wildcard usage and enforce mutual exclusivity with explicit pagination parameters
  • Comprehensive test updates to reflect the new naming convention

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cloudsmith_cli/data/VERSION Version bump to 1.9.5
.bumpversion.cfg Updated version configuration to 1.9.5
cloudsmith_cli/core/pagination.py Renamed show_all parameter to page_all throughout, updated comments and docstrings
cloudsmith_cli/cli/validators.py Added IntOrWildcard type, renamed enforce_show_all_exclusive to enforce_page_all_exclusive, enhanced validation for wildcard usage
cloudsmith_cli/cli/decorators.py Updated --page-all option with --show-all alias, changed --page-size to use IntOrWildcard type, added wildcard handling logic
cloudsmith_cli/cli/utils.py Renamed show_all parameter to page_all in pretty_print_list_info
cloudsmith_cli/cli/commands/upstream.py Updated function signatures and calls to use page_all instead of show_all
cloudsmith_cli/cli/commands/repos.py Updated function signatures and calls to use page_all instead of show_all
cloudsmith_cli/cli/commands/policy/vulnerability.py Updated function signatures and calls to use page_all instead of show_all
cloudsmith_cli/cli/commands/policy/license.py Updated function signatures and calls to use page_all instead of show_all
cloudsmith_cli/cli/commands/list_.py Updated function signatures and calls to use page_all instead of show_all
cloudsmith_cli/cli/tests/commands/test_upstream.py Updated test cases to use --page-all instead of --show-all
cloudsmith_cli/cli/tests/commands/test_repos.py Updated test cases to use --page-all and added test for --page-size -1
cloudsmith_cli/cli/tests/commands/test_package_commands.py Updated test case to use --page-all instead of --show-all
cloudsmith_cli/cli/tests/commands/policy/test_vulnerability.py Updated test cases and added test for --page-size * wildcard usage
cloudsmith_cli/cli/tests/commands/policy/test_licence.py Updated test cases to use --page-all instead of --show-all

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@chrisimcevoy chrisimcevoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests which exercise the alias?

@BartoszBlizniak
Copy link
Copy Markdown
Member Author

Can we add tests which exercise the alias?

Eagle eye - added to licesnse test

@BartoszBlizniak
Copy link
Copy Markdown
Member Author

Latest changes include:

  • Refactor for newly added Deny rules

I've also noticed a race condition when parallel testing the deny rules where instance would perform tests against the same org, due to forcing uniqueness on the query string for deny rules, this resulted in 400 errors in subsequent tests. To fix this, I have added a random string generator and appended name:<random_string> to fix this.

@BartoszBlizniak BartoszBlizniak merged commit a8e8570 into master Dec 16, 2025
13 checks passed
@BartoszBlizniak BartoszBlizniak deleted the ceng-605-update-show-all-to-page-all branch December 16, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants