fix: docs 352 navigation pane not functioning properly on safari#432
Merged
niallobrien merged 2 commits intoMay 29, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Safari-specific sidenav layout issues (notably under page zoom) by stabilizing the sidebar chevron icon’s layout/rotation behavior, and adjusts sidenav expand/collapse handling for hash-anchor “parent” items (e.g. Developer Tools) to avoid unintended menu state changes.
Changes:
- Added a
disableAnimationoption toChevronSmallIconto allow non-motion SVG rotation viatransform. - Updated
Sidenavitem click handling to (a) only toggle expansion for expandable items and (b) treat hash-anchor parents as expand/collapse-only within the sidenav. - Reworked sidenav chevron markup/CSS to pin icon sizing/positioning and avoid Safari zoom spacing glitches.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/icons/svgs/ChevronSmall.tsx | Adds disableAnimation and switches rotation handling to support a non-animated SVG path transform. |
| src/components/Sidenav/Sidenav.tsx | Fixes expand/collapse logic (including hash-anchor parent behavior) and wraps chevron for more stable layout. |
| src/components/Sidenav/Sidenav.module.css | Updates icon sizing/positioning styles to prevent zoom-induced spacing/layout issues in Safari. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aptkingston
approved these changes
May 29, 2026
Contributor
aptkingston
left a comment
aptkingston
left a comment
There was a problem hiding this comment.
LGTM! Tested in Safari 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Safari issue when page zooming causing the left navbar item spacing to screw up. I narrowed it down to the chevron icon in the sidebar.
While I was in here, I also addressed a related bug with the
developer toolsmenu item (it caused other menu items to expand/collapse).Here I have
productionopen in the first tab, and my local fix open in the second.https://github.com/user-attachments/assets/61679eb2-2e41-4c54-b258-cc7c011f07ee