Conversation
neykov
left a comment
neykov
left a comment
There was a problem hiding this comment.
Looks good, could improve karaf instructions as seems the updates are targeted at karaf.
| customizers: | ||
| - $brooklyn:object: | ||
| type: brooklyn.location.blockstore.ec2.Ec2NewVolumeCustomizer | ||
| type: io.brooklyn.blockstore.brooklyn-blockstore:brooklyn.location.blockstore.NewVolumeCustomizer |
There was a problem hiding this comment.
The changes here assume Karaf distribution, while the instructions above still document how to add dependencies to the classic distribution.
Ideally this should be added as a catalog item with catalog.libraries pointing to the blockstore jar. Alternatively could instruct the user to copy to deploy folder.
Do you think above instructions should be updated for karaf?
| @@ -90,15 +113,15 @@ This module should be built as an OSGi bundle, so that it can more easily be add | |||
| The API is under review, particularly to make it easier to use with YAML blueprints. | |||
There was a problem hiding this comment.
A couple of lines above:
This module should be built as an OSGi bundle, so that it can more easily be added to Brooklyn.
This should already be the case.
|
Good to merge, karaf doc updates can be done in another PR. |
bostko
force-pushed
the
update-readme
branch
2 times, most recently
from
7a4ee72 to
4ccec74
Compare
| This project builds on the open-source project Apache Brooklyn (see | ||
| http://brooklyn.apache.org and https://github.com/apache/brooklyn). | ||
| git clone git@github.com:cloudsoft/brooklyn-blockstore.git | ||
| mvn clean install |
neykov
left a comment
neykov
left a comment
There was a problem hiding this comment.
Some small changes to the examples needed, otherwise looks good.
| The example below creates a VM with a new volume: | ||
|
|
||
| brooklyn.catalog: | ||
| brooklyn.catalog: |
| brooklyn.catalog: | ||
| brooklyn.catalog: | ||
| id: my-app.io.cloudsoft.brooklyn-blockstore.new-volume-customizer | ||
| version: 0.6.0-SNAPSHOT |
There was a problem hiding this comment.
Tag the version so its updated when bumping to a new version. Use BROOKLYN_BLOCKSTORE_VERSION, I think html comments will hide it for the user.
| id: my-app.io.cloudsoft.brooklyn-blockstore.new-volume-customizer | ||
| version: 0.6.0-SNAPSHOT | ||
| brooklyn.libraries: | ||
| - file://home/myUser/repos/cloudsoft/brooklyn-blockstore/target/brooklyn-blockstore-0.6.0-SNAPSHOT.jar |
There was a problem hiding this comment.
Tag the version here as well.
There was a problem hiding this comment.
If the instructions recommend building locally, better use ~/.m2/repository/.....
There was a problem hiding this comment.
@neykov does Apache Brooklyn support ~ for file:// catalog libraries?
There was a problem hiding this comment.
Yes, I think it will recognise it.
| mountPoint: /mount/brooklyn/h | ||
| filesystemType: ext4 | ||
| brooklyn.catalog: | ||
| brooklyn.catalog: |
There was a problem hiding this comment.
Same comments as above snippet - double catalog, tag the version.
| filesystemType: ext4 | ||
| cd ${BROOKLYN_BLOCKSTORE_REPO} | ||
|
|
||
| echo Follow Apache Brooklyn Getting Started instructions from https://brooklyn.apache.org/#get-started |
There was a problem hiding this comment.
Section above (3 lines shell script) no longer useful, remove altogether.
|
@neykov I addressed you comments. |
2 participants
No description provided.