Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Add dependency and installation instructions#26

Merged
marcellanz merged 3 commits intocloudstateio:masterfrom
sleipnir:master
May 23, 2020
Merged

Add dependency and installation instructions#26
marcellanz merged 3 commits intocloudstateio:masterfrom
sleipnir:master

Conversation

@sleipnir
Copy link
Copy Markdown

No description provided.

@sleipnir sleipnir requested a review from marcellanz May 20, 2020 13:14
Copy link
Copy Markdown
Contributor

@marcellanz marcellanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sleipnir that looks good to me.

Comment thread README.md
Python 3.7.3
> pip --version
> pip install -r requirements.txt
```
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cloned a repo and after this step, I could not start ./tck.sh but after pip install . I where.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sleipnir wdyt?

Comment thread README.md

### generate installer
```
./venv/bin/python3 setup.py bdist_wheel
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sleipnir
I get this executing bdist_wheel. I read I need ti pip install wheel?

(venv) ➜  python-support git:(master) ✗ ./venv/bin/python3 setup.py bdist_wheel
package name: cloudstate, version: 0.5.0
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: invalid command 'bdist_wheel'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, after

pip install wheel

the next command installed the module.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! That was missing to mention, but we need it if we want to publish

@marcellanz
Copy link
Copy Markdown
Contributor

@sleipnir please find two comments above, after I tried it locally. I have nearly nothing python wise on my box, and this might be the reason the wheel module is not available on my machine.

@sleipnir
Copy link
Copy Markdown
Author

@sleipnir please find two comments above, after I tried it locally. I have nearly nothing python wise on my box, and this might be the reason the wheel module is not available on my machine.

I made some changes, see if it's cool

@marcellanz marcellanz changed the title Add dependency and instalation instructions Add dependency and installation instructions May 20, 2020
@marcellanz
Copy link
Copy Markdown
Contributor

@sleipnir please find two comments above, after I tried it locally. I have nearly nothing python wise on my box, and this might be the reason the wheel module is not available on my machine.

I made some changes, see if it's cool

thank you @sleipnir, I can have a look tomorrow - today was a holyday and too much sun to enjoy 😀

@sleipnir
Copy link
Copy Markdown
Author

@marcellanz Very good, enjoy

@marcellanz
Copy link
Copy Markdown
Contributor

Thank you @sleipnir

@marcellanz marcellanz closed this May 22, 2020
@marcellanz marcellanz reopened this May 23, 2020
@marcellanz marcellanz merged commit 0f5843f into cloudstateio:master May 23, 2020
@marcellanz
Copy link
Copy Markdown
Contributor

@sleipnir oops, closed the PR yesterday without merging. fixed!

owlet-labs pushed a commit to owlet-labs/python-support that referenced this pull request Sep 15, 2020
Add dependency and installation instructions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants