Support storing the kms encrypted value in a file

[mwildehahn]

No description provided.

[phobologic]

What do you think about making this more generic so that it's used by every translator?

Also is it worth using urlparse instead of the raw split you do here? You could parse it with urlparse, and if there is no scheme, then just use the raw value? Maybe it's not worth it at this point.

[mwildehahn]

i refactored this to a function that could potentially be used by other translators. i'd wait on making it more complex until we need to

[mwildehahn]

not sure if we should cache the result of _get_config_directory since we have argparse open the file and parse the env file, it could have some overhead if you have multiple kms values

[phobologic]

Both of these helper functions seem useful/generic enough that I think they should probably be in the base translators module - I could see other translators, in the future, wanting to use them.

[mwildehahn]

makes sense

[phobologic]

While we don't have full docs, this feature is useful enough that I think it might be worth mentioning the use of file:// as well as just putting a string in the field in the section of the README.rst that discusses translators.

[phobologic]

👍