Skip to content

chore: allow queued runs for build pgo actions#2226

Merged
gabriel-aranha-cw merged 2 commits intomainfrom
chore-allow-queued-runs-build-pgo
Aug 11, 2025
Merged

chore: allow queued runs for build pgo actions#2226
gabriel-aranha-cw merged 2 commits intomainfrom
chore-allow-queued-runs-build-pgo

Conversation

@gabriel-aranha-cw
Copy link
Contributor

@gabriel-aranha-cw gabriel-aranha-cw commented Aug 11, 2025

User description

This improvement makes queued runs not get cancelled if a new PR is merged in the meantime a build is running. For build actions it is ideal that each PR is merged and its build actions executed sequentially and not get skipped.


PR Type

Enhancement


Description

  • Modify concurrency settings in GitHub Actions workflows

  • Set cancel-in-progress to false for build actions

  • Ensure sequential PR merging for build processes

  • Prevent cancellation of queued runs on new PR merges


Diagram Walkthrough

flowchart LR
  A["GitHub Actions Workflows"] --> B["Concurrency Settings"]
  B --> C["cancel-in-progress: false"]
  C --> D["Sequential PR Merging"]
  D --> E["Prevent Queued Run Cancellation"]
Loading

File Walkthrough

Relevant files
Configuration changes
build-pgo-optimized.yml
Update concurrency settings for PGO optimized build           

.github/workflows/build-pgo-optimized.yml

  • Changed cancel-in-progress from true to false in concurrency settings
+1/-1     
build-pgo.yml
Update concurrency settings for PGO build                               

.github/workflows/build-pgo.yml

  • Changed cancel-in-progress from true to false in concurrency settings
+1/-1     

@gabriel-aranha-cw gabriel-aranha-cw changed the title chore: allow queued runs build pgo actions chore: allow queued runs for build pgo actions Aug 11, 2025
@gabriel-aranha-cw gabriel-aranha-cw marked this pull request as ready for review August 11, 2025 17:32
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

PR Reviewer Guide 🔍

(Review updated until commit 4538886)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link
Contributor

Persistent review updated to latest commit 4538886

@github-actions
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

1 similar comment
@github-actions
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.99%. Comparing base (23bd196) to head (695c465).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2226      +/-   ##
==========================================
+ Coverage   81.18%   83.99%   +2.81%     
==========================================
  Files         131      131              
  Lines       10523    10523              
==========================================
+ Hits         8543     8839     +296     
+ Misses       1980     1684     -296     
Flag Coverage Δ
contracts-rocks- 46.66% <ø> (+0.02%) ⬆️
e2e-admin-password 23.13% <ø> (ø)
e2e-clock-stratus 25.92% <ø> (ø)
e2e-genesis 27.64% <ø> (ø)
e2e-importer-offline 61.28% <ø> (?)
e2e-rpc-downloader 56.21% <ø> (ø)
e2e-stratus 57.59% <ø> (+0.01%) ⬆️
leader-follower- 63.00% <ø> (-0.03%) ⬇️
rust-tests 30.19% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriel-aranha-cw gabriel-aranha-cw enabled auto-merge (squash) August 11, 2025 17:46
@gabriel-aranha-cw gabriel-aranha-cw merged commit f33caab into main Aug 11, 2025
36 checks passed
@gabriel-aranha-cw gabriel-aranha-cw deleted the chore-allow-queued-runs-build-pgo branch August 11, 2025 17:54
@gabriel-aranha-cw
Copy link
Contributor Author

Final benchmark:
Run ID: bench-0bac435a

Git Info:

Leader Stats:
RPS Stats: Max: 3474.00, Min: 1717.00, Avg: 2890.20, StdDev: 155.61
TPS Stats: Max: 3217.00, Min: 170.00, Avg: 2882.15, StdDev: 208.57

Follower Stats:
Imported Blocks/s: No imported blocks data
Imported Transactions/s: No imported transactions data

Plots:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments