chore: allow queued runs for build pgo actions#2226
Conversation
PR Reviewer Guide 🔍(Review updated until commit 4538886)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 4538886 |
PR Code Suggestions ✨No code suggestions found for the PR. |
1 similar comment
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
+ Coverage 81.18% 83.99% +2.81%
==========================================
Files 131 131
Lines 10523 10523
==========================================
+ Hits 8543 8839 +296
+ Misses 1980 1684 -296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Final benchmark: Git Info:
Leader Stats: Follower Stats: Plots: |
User description
This improvement makes queued runs not get cancelled if a new PR is merged in the meantime a build is running. For build actions it is ideal that each PR is merged and its build actions executed sequentially and not get skipped.
PR Type
Enhancement
Description
Modify concurrency settings in GitHub Actions workflows
Set
cancel-in-progressto false for build actionsEnsure sequential PR merging for build processes
Prevent cancellation of queued runs on new PR merges
Diagram Walkthrough
File Walkthrough
build-pgo-optimized.yml
Update concurrency settings for PGO optimized build.github/workflows/build-pgo-optimized.yml
cancel-in-progressfrom true to false in concurrency settingsbuild-pgo.yml
Update concurrency settings for PGO build.github/workflows/build-pgo.yml
cancel-in-progressfrom true to false in concurrency settings