Skip to content

chore: show full output on check unused deps workflow#2237

Merged
carneiro-cw merged 1 commit intomainfrom
output_unused_deps
Aug 12, 2025
Merged

chore: show full output on check unused deps workflow#2237
carneiro-cw merged 1 commit intomainfrom
output_unused_deps

Conversation

@carneiro-cw
Copy link
Contributor

@carneiro-cw carneiro-cw commented Aug 12, 2025

PR Type

Enhancement


Description

  • Simplified unused dependencies check using Just

  • Added setup for Just command runner

  • Removed manual cargo udeps execution and output parsing

  • Streamlined workflow for better maintainability


Diagram Walkthrough

flowchart LR
  A["Manual cargo udeps"] --> B["Just command"]
  C["Output parsing"] --> D["Simplified check"]
  E["Workflow steps"] --> F["Streamlined process"]
Loading

File Walkthrough

Relevant files
Enhancement
check-unused-deps.yml
Simplify unused dependencies check using Just                       

.github/workflows/check-unused-deps.yml

  • Added step to set up Just command runner
  • Replaced manual cargo udeps execution with just check-unused-deps
  • Removed complex output parsing and error checking logic
  • Simplified the workflow by delegating logic to Just command
+4/-13   

@github-actions
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Logging Removal

The PR removes detailed logging of unused dependencies. Consider if this reduction in output might impact the ability to quickly identify and address unused dependencies.

- name: Check for unused dependencies
  run: just check-unused-deps

@github-actions
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Add error handling and logging

Consider adding error handling and output capture to the 'just check-unused-deps'
command. This will ensure that any failures or important output are properly logged
and visible in the GitHub Actions workflow.

.github/workflows/check-unused-deps.yml [58-59]

 - name: Check for unused dependencies
-  run: just check-unused-deps
+  run: |
+    set -eo pipefail
+    output=$(just check-unused-deps 2>&1) || { echo "Error: $output"; exit 1; }
+    echo "$output"
Suggestion importance[1-10]: 7

__

Why: The suggestion improves error handling and output visibility for the just check-unused-deps command, which is important for debugging and maintaining the CI pipeline. However, it's not addressing a critical issue, so it doesn't warrant a higher score.

Medium

@codecov
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.98%. Comparing base (cd0ea93) to head (1fa726b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   84.05%   83.98%   -0.07%     
==========================================
  Files         131      131              
  Lines       10523    10523              
==========================================
- Hits         8845     8838       -7     
- Misses       1678     1685       +7     
Flag Coverage Δ
contracts-rocks- 46.63% <ø> (+0.02%) ⬆️
e2e-admin-password 23.13% <ø> (ø)
e2e-clock-stratus 25.92% <ø> (ø)
e2e-genesis 27.64% <ø> (ø)
e2e-importer-offline 61.40% <ø> (+0.12%) ⬆️
e2e-rpc-downloader 56.36% <ø> (-0.03%) ⬇️
e2e-stratus 57.57% <ø> (ø)
leader-follower- 62.99% <ø> (-0.06%) ⬇️
rust-tests 30.19% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carneiro-cw carneiro-cw merged commit a34f81a into main Aug 12, 2025
36 of 37 checks passed
@carneiro-cw carneiro-cw deleted the output_unused_deps branch August 12, 2025 20:15
@stratus-benchmark
Copy link

Final benchmark:
Run ID: bench-42611cbb

Git Info:

Leader Stats:
RPS Stats: Max: 3174.00, Min: 2044.00, Avg: 2787.01, StdDev: 161.42
TPS Stats: Max: 3159.00, Min: 621.00, Avg: 2780.81, StdDev: 199.99

Follower Stats:
Imported Blocks/s: No imported blocks data
Imported Transactions/s: No imported transactions data

Plots:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments