Skip to content

refactor: remove file descriptor limit setting functionality#2281

Merged
gabriel-aranha-cw merged 2 commits intomainfrom
bronzelle/feature/remove-ulimit-set
Sep 1, 2025
Merged

refactor: remove file descriptor limit setting functionality#2281
gabriel-aranha-cw merged 2 commits intomainfrom
bronzelle/feature/remove-ulimit-set

Conversation

@bronzelle-cw
Copy link
Contributor

Summary

This PR removes the automatic file descriptor limit setting functionality while preserving the checking and warning capabilities.

Background

In a previous PR, we implemented functionality to:

  1. Check file descriptor limits
  2. Automatically set new file descriptor limits if they were below the threshold

After the previous PR was merged to main, we encountered issues with the automatic setting functionality and decided to remove that part while keeping only the checking functionality.

Changes

  • Removed create_file_descriptor_error_message function
  • Removed set_file_descriptor_limit function that attempted to automatically increase file descriptor limits
  • Simplified get_current_file_descriptor_limit to only retrieve current limits
  • Updated check_file_descriptor_limit to only check and warn about insufficient limits, returning an error instead of attempting to fix them automatically
  • Removed test case for the automatic setting functionality

Behavior Change

Before: If file descriptor limit was below threshold, Stratus would attempt to automatically increase it.

After: If file descriptor limit is below threshold, Stratus will log a warning and return an error, requiring manual intervention.

Testing

  • Existing unit tests pass
  • The file descriptor limit checking functionality remains intact
  • Manual testing shows appropriate warnings are logged when limits are insufficient

This approach is safer as it avoids potential system-level modifications and clearly communicates to users when manual configuration is needed.

@bronzelle-cw bronzelle-cw force-pushed the bronzelle/feature/remove-ulimit-set branch from 2c598bb to b443854 Compare August 29, 2025 14:08
@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.54%. Comparing base (bc8779c) to head (e2598c5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/eth/storage/permanent/rocks/rocks_permanent.rs 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
+ Coverage   84.14%   84.54%   +0.39%     
==========================================
  Files         129      129              
  Lines       10409    10395      -14     
==========================================
+ Hits         8759     8788      +29     
+ Misses       1650     1607      -43     
Flag Coverage Δ
contracts-rocks- 45.31% <25.00%> (+0.04%) ⬆️
e2e-admin-password 22.57% <25.00%> (?)
e2e-clock-stratus 25.40% <25.00%> (+0.04%) ⬆️
e2e-genesis 26.93% <25.00%> (+0.05%) ⬆️
e2e-importer-offline 59.86% <25.00%> (+0.08%) ⬆️
e2e-rpc-downloader 54.77% <25.00%> (-0.06%) ⬇️
e2e-stratus 56.23% <25.00%> (+0.08%) ⬆️
leader-follower- 62.92% <25.00%> (+0.68%) ⬆️
rust-tests 29.66% <62.50%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gabriel-aranha-cw gabriel-aranha-cw enabled auto-merge (squash) September 1, 2025 18:34
@gabriel-aranha-cw gabriel-aranha-cw merged commit 73b44b5 into main Sep 1, 2025
39 of 41 checks passed
@gabriel-aranha-cw gabriel-aranha-cw deleted the bronzelle/feature/remove-ulimit-set branch September 1, 2025 18:45
@stratus-benchmark
Copy link

Final benchmark:
Run ID: bench-ad654e68

Git Info:

Leader Stats:
RPS Stats: Max: 6798.00, Min: 3848.00, Avg: 6124.92, StdDev: 260.73
TPS Stats: Max: 3356.00, Min: 665.00, Avg: 3057.00, StdDev: 178.94

Follower Stats:
Imported Blocks/s: Max: 12.00, Min: 2.00, Avg: 7.96, StdDev: 2.03
Imported Transactions/s: Max: 28085.00, Min: 6028.00, Avg: 20332.01, StdDev: 3809.70

Plots:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments