refactor: remove file descriptor limit setting functionality#2281
Merged
gabriel-aranha-cw merged 2 commits intomainfrom Sep 1, 2025
Merged
refactor: remove file descriptor limit setting functionality#2281gabriel-aranha-cw merged 2 commits intomainfrom
gabriel-aranha-cw merged 2 commits intomainfrom
Conversation
2c598bb to
b443854
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
==========================================
+ Coverage 84.14% 84.54% +0.39%
==========================================
Files 129 129
Lines 10409 10395 -14
==========================================
+ Hits 8759 8788 +29
+ Misses 1650 1607 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gabriel-aranha-cw
approved these changes
Sep 1, 2025
gabriel-aranha-cw
approved these changes
Sep 1, 2025
|
Final benchmark: Git Info:
Leader Stats: Follower Stats: Plots: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the automatic file descriptor limit setting functionality while preserving the checking and warning capabilities.
Background
In a previous PR, we implemented functionality to:
After the previous PR was merged to main, we encountered issues with the automatic setting functionality and decided to remove that part while keeping only the checking functionality.
Changes
create_file_descriptor_error_messagefunctionset_file_descriptor_limitfunction that attempted to automatically increase file descriptor limitsget_current_file_descriptor_limitto only retrieve current limitscheck_file_descriptor_limitto only check and warn about insufficient limits, returning an error instead of attempting to fix them automaticallyBehavior Change
Before: If file descriptor limit was below threshold, Stratus would attempt to automatically increase it.
After: If file descriptor limit is below threshold, Stratus will log a warning and return an error, requiring manual intervention.
Testing
This approach is safer as it avoids potential system-level modifications and clearly communicates to users when manual configuration is needed.