Skip to content

fix(CI): install latest cargo-pgo version#2455

Merged
carneiro-cw merged 1 commit intomainfrom
fix_pgo
Feb 27, 2026
Merged

fix(CI): install latest cargo-pgo version#2455
carneiro-cw merged 1 commit intomainfrom
fix_pgo

Conversation

@carneiro-cw
Copy link
Copy Markdown
Contributor

Before we used a version from a test branch because of some feature we needed (don't remember what exactly), the branch has been merged and deleted, breaking the action.

@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Cargo Install Locking

The new cargo install --vers 0.3.0 cargo-pgo invocation no longer includes --locked.
Adding --locked helps ensure reproducible installs aligned with Cargo.lock.

run: cargo install --vers 0.3.0 cargo-pgo
Cargo Install Force Update

Without --force, rerunning CI may skip updating an existing cargo-pgo install.
Consider adding --force to guarantee the correct version is installed on each run.

run: cargo install --vers 0.3.0 cargo-pgo

@github-actions
Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Force reinstall pinned version

Add the --force flag to the install command to ensure the specified version is
installed even if an older version is already present in the environment. This
prevents CI from reusing a stale binary.

.github/workflows/build-pgo-optimized.yml [59]

-run: cargo install --vers 0.3.0 cargo-pgo
+run: cargo install --vers 0.3.0 --force cargo-pgo
Suggestion importance[1-10]: 4

__

Why: Adding --force ensures Cargo overrides any existing cargo-pgo binary and avoids CI failures from stale installations, slightly improving build reliability.

Low

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c0812a447

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/build-pgo.yml
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.38%. Comparing base (d5188d5) to head (1c0812a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   84.41%   84.38%   -0.04%     
==========================================
  Files         141      141              
  Lines       10808    10808              
==========================================
- Hits         9124     9120       -4     
- Misses       1684     1688       +4     
Flag Coverage Δ
contracts-rocks-asset-transit-desk 43.62% <ø> (-0.03%) ⬇️
contracts-rocks-balance-freezer 42.71% <ø> (ø)
contracts-rocks-balance-tracker 43.06% <ø> (ø)
contracts-rocks-base 43.62% <ø> (ø)
contracts-rocks-blueprint 43.97% <ø> (ø)
contracts-rocks-capybara-finance 44.29% <ø> (ø)
contracts-rocks-capybara-finance-v2 44.36% <ø> (ø)
contracts-rocks-card-payment-processor 44.06% <ø> (ø)
contracts-rocks-card-payment-processor-v2 44.36% <ø> (ø)
contracts-rocks-cashier 43.97% <ø> (ø)
contracts-rocks-credit-agent 43.26% <ø> (ø)
contracts-rocks-multisig 43.95% <ø> (ø)
contracts-rocks-net-yield-distributor 43.97% <ø> (-0.03%) ⬇️
contracts-rocks-periphery 42.71% <ø> (ø)
contracts-rocks-shared-wallet-controller 44.00% <ø> (-0.03%) ⬇️
contracts-rocks-token 44.06% <ø> (-0.03%) ⬇️
contracts-rocks-treasury 43.68% <ø> (ø)
e2e-admin-password 22.84% <ø> (ø)
e2e-clock-stratus 25.69% <ø> (ø)
e2e-genesis 27.22% <ø> (ø)
e2e-importer-offline 60.15% <ø> (ø)
e2e-rpc-downloader 55.15% <ø> (ø)
e2e-stratus 57.63% <ø> (ø)
leader-follower- 61.67% <ø> (-0.05%) ⬇️
rust-tests 30.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carneiro-cw carneiro-cw enabled auto-merge (squash) February 27, 2026 16:09
@carneiro-cw carneiro-cw merged commit 8599c5e into main Feb 27, 2026
51 of 53 checks passed
@carneiro-cw carneiro-cw deleted the fix_pgo branch February 27, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants