Skip to content

Conversation

@yewanting
Copy link
Contributor

What type of PR is this?

fix : A bug fix and reafactor

Check the PR title.

fix: modify monorepo package detection and parsing logic

(Optional) Translate the PR title into Chinese.

fix: 修改 monorepo 包检测逻辑和解析逻辑

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
Core Logic Changes

  • Before : isMonorepo() differentiated between various monorepo types (Eden, pnpm, Lerna) by checking specific configuration files (eden.monorepo.json, pnpm-workspace.yaml, lerna.json, etc.) ; Applied different logic based on the detected monorepo type
  • Now : isMonorepo() uniformly determines monorepo status by counting package.json files (>= 2 package.json files means it's a monorepo); Uses a unified package.json discovery mechanism, ignoring monorepo types

zh:
核心逻辑变更

  • 之前 : isMonorepo() 区分 Eden、pnpm、Lerna 等不同 monorepo 类型,通过检查特定的配置文件(eden.monorepo.json、pnpm-workspace.yaml、lerna.json 等);根据不同的类型去做不同的逻辑判断
  • 现在 : isMonorepo() 统一通过计算 package.json 文件数量来判断(>= 2 个 package.json 即为 monorepo); 统一使用 package.json 检测机制,忽略 monorepo 类型

(Optional) Which issue(s) this PR fixes:

Some EMO projects were parsed inaccurately

Copy link
Collaborator

@angrychow angrychow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Duslia Duslia merged commit 8bfb37a into cloudwego:main Nov 13, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants