fix(golang): skip out-of-repo local replace targets to avoid nil panic#188
Merged
Duslia merged 2 commits intocloudwego:mainfrom May 8, 2026
Merged
Conversation
Local `replace => /abs` or `replace => ../outside` targets are not walked by collectGoMods, so they are absent from p.repo.Modules. ParseRepo's old `@`-based skip didn't filter them, causing a nil deref on mod.Dir. Switch ParseRepo's skip to the canonical signal (mod == nil) and have getDeps only record local replace deps whose target lives inside the repo root. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Duslia
approved these changes
May 8, 2026
…ion entries Switching the skip purely to mod==nil broke deduplication: getDeps writes deps[self] = self+'@'+commit for the current module (via getCommitHash), and that self-entry has mod != nil, so it triggered an extra ParseModule pass that re-walked the dir and reset Files entries (clearing Imports / Package on already-parsed files in submodules). Restore the existing strings.Contains(lib.path, "@") skip and add the mod == nil guard after it — that catches out-of-repo local-replace entries (which carry no '@' since they have no version) without breaking the self-version dedup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local
replace => /absorreplace => ../outsidetargets are not walked by collectGoMods, so they are absent from p.repo.Modules. ParseRepo's old@-based skip didn't filter them, causing a nil deref on mod.Dir.Switch ParseRepo's skip to the canonical signal (mod == nil) and have getDeps only record local replace deps whose target lives inside the repo root.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
修复当存在 Replace 到外部时，ABCoder panic 的问题
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: