-
Notifications
You must be signed in to change notification settings - Fork 36
feat(java/parser):support java #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d-java # Conflicts: # lang/lsp/lsp.go # lang/parse.go # lang/uniast/ast.go
|
可以先签署一下 cla 哈 |
|
JDT 能做到用户按需安装码吗?类似:
|
脚本已提供,可以支持用户自定义JDT和默认JDT 路径 |
|
Part of #64 |
welkeyever
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testdata 统一放到根目录下吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
PS: 理想架构应该是将 tree-sitter binding 封装为一套接口,直接内嵌到 Collect 过程中。不过改动其他parser实现现在确实也不在本次pr的职责范围呢,就先这样吧。后面有兴趣可以一起看看怎么整体重构一下 @Huabuxiu @Hoblovski |
还是说我们最后 squash?那样的话就别管了 |
squash 下吧 |
|
CI 挂了,是不是文件要加版权 header? |
|
@Huabuxiu These files need to add the license header: |
done |
前面三个仓库 是测试 解析部分功能用的 repo file,给小UT 用的 , 加了一个 带mvn项目管理的 第四个,可以试试跑一下parse 看看 |
|
0_HelloWorld 里代码有语法错误,tree sitter 居然会自动修复? |
tree sitter 在这里用法是 单文件词法解析,没有校验语法正确性,所以能识别出来这个格式 |
lang/collect/collect.go
Outdated
| "context" | ||
| "fmt" | ||
| "github.com/cloudwego/abcoder/lang/java" | ||
| javaparser "github.com/cloudwego/abcoder/lang/java/parser" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import 可以顺带 format 下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Hoblovski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
解决一下冲突然后 squash 吧?
7551392 to
940796b
Compare
|
Moved to #88 |





What type of PR is this?
feat: support java parser with tree-sitter and jdt-ls lsp
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation:
more detail of this pr : docs/tree-sitter_and_lsp_zh.md