feat(adk): turn loop support front and exit loop#796
Merged
meguminnnnnnnnn merged 1 commit intofeat/agent_turn_loopfrom Feb 21, 2026
Merged
feat(adk): turn loop support front and exit loop#796meguminnnnnnnnn merged 1 commit intofeat/agent_turn_loopfrom
meguminnnnnnnnn merged 1 commit intofeat/agent_turn_loopfrom
Conversation
hi-pender
reviewed
Feb 20, 2026
| }, nil | ||
| } | ||
|
|
||
| var ErrLoopExit = errors.New("loop exit") |
Contributor
There was a problem hiding this comment.
直接采用 EOF error 这个语义，感觉就够了
Contributor
Author
There was a problem hiding this comment.
EOF 是 io.EOF，这里有不涉及读，感觉不好吧
Contributor
There was a problem hiding this comment.
咱们的 StreamReader 也是采用 io.EOF 作为结束标记的。 这里的 Receive/Front 感觉都是类似的
Contributor
Author
There was a problem hiding this comment.
这个是定义给用户的用的，用户不知道 queue eof 了会发生什么，得告诉他们是停止循环。 而且 on agent events 也要判断这个
Contributor
There was a problem hiding this comment.
自定义的是多了一点语义： 要停止 Loop。
先用这个 error 吧
hi-pender
approved these changes
Feb 20, 2026
hi-pender
pushed a commit
that referenced
this pull request
Feb 24, 2026
hi-pender
pushed a commit
that referenced
this pull request
Feb 27, 2026
meguminnnnnnnnn
added a commit
that referenced
this pull request
Feb 28, 2026
hi-pender
pushed a commit
that referenced
this pull request
Mar 3, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 4, 2026
Closed
shentongmartin
pushed a commit
that referenced
this pull request
Mar 5, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 19, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 23, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 30, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 7, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 8, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 8, 2026
mrh997
pushed a commit
that referenced
this pull request
Apr 10, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 13, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 14, 2026
N3kox
pushed a commit
that referenced
this pull request
Apr 14, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 14, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: