fix: implement IsCallbacksEnabled and GetType for cancelableChatModel#826
Merged
hi-pender merged 1 commit intofeat/agent_turn_loopfrom Mar 2, 2026
Merged
fix: implement IsCallbacksEnabled and GetType for cancelableChatModel#826hi-pender merged 1 commit intofeat/agent_turn_loopfrom
hi-pender merged 1 commit intofeat/agent_turn_loopfrom
Conversation
shentongmartin
approved these changes
Mar 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/agent_turn_loop #826 +/- ##
=======================================================
Coverage ? 79.53%
=======================================================
Files ? 148
Lines ? 16425
Branches ? 0
=======================================================
Hits ? 13064
Misses ? 2386
Partials ? 975 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hi-pender
added a commit
that referenced
this pull request
Mar 3, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 4, 2026
Closed
shentongmartin
pushed a commit
that referenced
this pull request
Mar 5, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 19, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 23, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Mar 30, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 7, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 8, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 8, 2026
mrh997
pushed a commit
that referenced
this pull request
Apr 10, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 13, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 14, 2026
N3kox
pushed a commit
that referenced
this pull request
Apr 14, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 14, 2026
shentongmartin
pushed a commit
that referenced
this pull request
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two interface methods to
cancelableChatModelto properly propagate callback and type information from the wrapped inner model.Changes
IsCallbacksEnabled() boolmethod to delegate callback status check to the inner modelGetType() stringmethod to return the type name of the inner modelWhy
The
cancelableChatModelwraps amodel.ChatModelto add cancellation support. However, without these methods, the wrapper would lose the ability to report:This ensures proper functionality when using the cancelable wrapper with the component callback system and type introspection.
Testing
The implementation delegates to existing utility functions (
components.IsCallbacksEnabled,components.GetType,generic.ParseTypeName) which are already tested.