test(adk): add WrapToolCall ToolMiddleware tests#906
Merged
zhuangjie1125 merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
Contributor
zhuangjie1125
commented
Mar 24, 2026
- Add 6 subtests for AgentMiddleware.WrapToolCall in TestChatModelAgentRun:
- Invokable middleware: basic invocation, argument capture
- Multiple middlewares: verify outer-to-inner execution order
- Modify result: middleware can alter tool output
- Streamable middleware: works with StreamableTool
- EnhancedInvokable middleware: works with EnhancedInvokableTool
- EnhancedStreamable middleware: works with EnhancedStreamableTool
- Add fakeEnhancedInvokableToolForTest and fakeEnhancedStreamableToolForTest helpers
- Fix collectToolMiddlewaresFromMiddlewares to also check EnhancedInvokable and EnhancedStreamable fields before skipping
- Fix deprecated comment in skill middleware (New -> NewMiddleware)
- Add 6 subtests for AgentMiddleware.WrapToolCall in TestChatModelAgentRun: - Invokable middleware: basic invocation, argument capture - Multiple middlewares: verify outer-to-inner execution order - Modify result: middleware can alter tool output - Streamable middleware: works with StreamableTool - EnhancedInvokable middleware: works with EnhancedInvokableTool - EnhancedStreamable middleware: works with EnhancedStreamableTool - Add fakeEnhancedInvokableToolForTest and fakeEnhancedStreamableToolForTest helpers - Fix collectToolMiddlewaresFromMiddlewares to also check EnhancedInvokable and EnhancedStreamable fields before skipping - Fix deprecated comment in skill middleware (New -> NewMiddleware)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 81.98% 82.17% +0.18%
==========================================
Files 146 146
Lines 16063 16063
==========================================
+ Hits 13170 13200 +30
+ Misses 1957 1916 -41
- Partials 936 947 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hi-pender
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.