optimize(gRPC): support pooling HTTP2 framer write buffer to reduce idle connection memory#1944
Merged
DMwangnima merged 1 commit intocloudwego:mainfrom Apr 13, 2026
Conversation
DMwangnima
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1944 +/- ##
==========================================
+ Coverage 61.37% 62.66% +1.28%
==========================================
Files 388 393 +5
Lines 35063 30089 -4974
==========================================
- Hits 21521 18855 -2666
+ Misses 12247 9940 -2307
+ Partials 1295 1294 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DMwangnima
force-pushed
the
optimize/grpc-framer-buf
branch
from
f764c0b to
76fe625
Compare
…idle memory Add EnableReuseHTTP2FramerBuffer to ReuseWriteBufferConfig. Allocate per-frame wbuf from mcache in startWrite and return after successful endWrite. On write failure the buffer is not returned, as the underlying writer may still hold a reference. Update WithGRPCReuseWriteBuffer godoc to describe both config switches. Add unit tests for zero-payload, large-payload and write-failure paths. Add integration test cases covering framer buffer pooling combinations.
DMwangnima
force-pushed
the
optimize/grpc-framer-buf
branch
from
76fe625 to
d172d09
Compare
DMwangnima
changed the title
ppzqh
approved these changes
Apr 13, 2026
xiaost
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
optimize
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
EnableReuseHTTP2FramerBuffertoReuseWriteBufferConfig.WithGRPCReuseWriteBuffercomment to describe both config switches.On write failure the buffer is not returned, as the underlying writer may still hold a reference.
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: