feat: add insertion point for typedef#296
Merged
HeyJavaBean merged 2 commits intocloudwego:mainfrom Sep 24, 2025
Merged
Conversation
Member
|
Thanks for your contribution. I understand your case, but I don't think it's necessary😢. Adding a new insertion point doesn't solve bugs or bring new features, just for code format, so I think the complexity it introduces outweighs the benefits. |
Contributor
Author
|
@HeyJavaBean Thank you for your explanation. However, I earnestly request a reconsideration of this. Many other templates have one or more insertion points of their own. All of them are valuable, right? So does |
Member
|
ok |
HeyJavaBean
approved these changes
Sep 24, 2025
Contributor
Author
|
@HeyJavaBean Thanks for reconsidering and merging this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an insertion point for typedef to provide convenience for plugins that add some stuff for typedef.
Motivation and Context
I built a plugin to support string enums, it works like
It works well; however, there's no
InsertionPointin the template for typedef, so I have to use theeofpoint, which makes the generated code hard to read: the additional code is far away from the definition of the type. 😢Related Issue
None.