chore(volo-http): adjust positions of some mods#499
Merged
yukiiiteru merged 2 commits intocloudwego:mainfrom Sep 19, 2024
Merged
chore(volo-http): adjust positions of some mods#499yukiiiteru merged 2 commits intocloudwego:mainfrom
yukiiiteru merged 2 commits intocloudwego:mainfrom
Conversation
To keep the crate simple, this commit adjusts positions of some mods: - Move functions from `volo_http::json` to `volo_http::utils::json` - Move extractor `Json` from `volo_http::json::Json` to `volo_http::server::extract::Json` - Move mod `extension` from `volo_http::extension` to `volo_http::utils::extension` - Move mod `cookie` from `volo_http::cookie` to `volo_http::utils::cookie` - Separate `volo_http::server::route` from `route.rs` into `route/mod.rs`, `route/router.rs`, `route/method_router.rs` and `route/utils.rs` This commit introduced the following break changes: - Position of `Json` was changed, `use volo_http::json::Json` -> `use volo_http::server::extract::Json` - Position of `Extension` was changed, `use volo_http::extension::Extension` -> `use volo_http::utils::Extension` - Position of `CookieJar` was changed, `use volo_http::cookie::CookieJar` -> `use volo_http::utils::cookie::CookieJar` - `Json` and `Extension` were not be re-exported in `volo_http`, user should import them by its full path. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
PureWhiteWu
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make Volo-HTTP simple and clean.
Solution
To keep the crate simple, this commit adjusts positions of some mods:
volo_http::jsontovolo_http::utils::jsonJsonfromvolo_http::json::Jsontovolo_http::server::extract::Jsonextensionfromvolo_http::extensiontovolo_http::utils::extensioncookiefromvolo_http::cookietovolo_http::utils::cookievolo_http::server::routefromroute.rsintoroute/mod.rs,route/router.rs,route/method_router.rsandroute/utils.rsThis commit introduced the following break changes:
Jsonwas changed,use volo_http::json::Json->use volo_http::server::extract::JsonExtensionwas changed,use volo_http::extension::Extension->use volo_http::utils::ExtensionCookieJarwas changed,use volo_http::cookie::CookieJar->use volo_http::utils::cookie::CookieJarJsonandExtensionwere not be re-exported involo_http, user should import them by its full path.