chore(volo-http): refactor RequestPartsExt#501
Merged
yukiiiteru merged 1 commit intocloudwego:mainfrom Sep 24, 2024
Merged
Conversation
PureWhiteWu
previously approved these changes
Sep 24, 2024
Ggiggle
previously approved these changes
Sep 24, 2024
The previous implementation of `RequestPartsExt` was inelegant and somewhat inaccurate, so we remove most functions in `RequestPartsExt`, implement it for both `http::request::Parts` and `http::request::Request`, move it from `volo_http::context::server` to `volo_http::request`. In addition, `RequestPartsExt::full_uri` has been changed to extractor `FullUri` because it depends status of tls. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
yukiiiteru
dismissed stale reviews from Ggiggle and PureWhiteWu
via
50ffc96
yukiiiteru
force-pushed
the
chore/request-ext
branch
from
70f28ed to
50ffc96
Compare
PureWhiteWu
approved these changes
Sep 24, 2024
Ggiggle
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previous implementation of
RequestPartsExtwas inelegant and somewhat inaccurate.Solution
Remove most functions in
RequestPartsExt, implement it for bothhttp::request::Partsandhttp::request::Request, move it fromvolo_http::context::servertovolo_http::request.In addition, we added two
HeaderName(X-Forwarded-ForandX-Real-IP) for future use.