chore(volo-http): wrap hyper::body::Incoming by Body#504
Merged
yukiiiteru merged 2 commits intocloudwego:mainfrom Sep 26, 2024
Merged
chore(volo-http): wrap hyper::body::Incoming by Body#504yukiiiteru merged 2 commits intocloudwego:mainfrom
hyper::body::Incoming by Body#504yukiiiteru merged 2 commits intocloudwego:mainfrom
Conversation
In order to unify the body type within Volo-HTTP, this commit wraps `hyper::body::Incoming` by `Body`, so that both client and server can use `http::Request` and `http::Response` with `Body`. In addition, with this commmit, client and server inside Volo-HTTP can communicate by function call without any connection, which is useful for testing. Althrough `hyper::body::Incoming` implements `http_body::Body`, use `enum` rather than `BoxBody` can avoid overhead of memory allocating by `Box` and dynamic dispatch of `dyn http_body::Body`. BREAK CHANGE: - `ServerRequest` has been changed from `http::Request<hyper::body::Incoming>` to `http::Request<Body>` - `ClientResponse` has been changed from `http::Response<hyper::body::Incoming>` to `http::Response<Body>` These are imperceptible to most users. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
PureWhiteWu
approved these changes
Sep 26, 2024
Contributor
Author
|
I've run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to unify the body type within Volo-HTTP, this commit wraps
hyper::body::IncomingbyBody, so that both client and server can usehttp::Requestandhttp::ResponsewithBody.In addition, with this commmit, client and server inside Volo-HTTP can communicate by function call without any connection, which is useful for testing.
Althrough
hyper::body::Incomingimplementshttp_body::Body, useenumrather thanBoxBodycan avoid overhead of memory allocating byBoxand dynamic dispatch ofdyn http_body::Body.BREAK CHANGE:
ServerRequesthas been changed fromhttp::Request<hyper::body::Incoming>tohttp::Request<Body>ClientResponsehas been changed fromhttp::Response<hyper::body::Incoming>tohttp::Response<Body>These are imperceptible to most users.