Skip to content

fix(#515): codegen and default problem#525

Merged
PureWhiteWu merged 1 commit intomainfrom
fix/issue_515
Nov 6, 2024
Merged

fix(#515): codegen and default problem#525
PureWhiteWu merged 1 commit intomainfrom
fix/issue_515

Conversation

@PureWhiteWu
Copy link
Copy Markdown
Contributor

@PureWhiteWu PureWhiteWu commented Nov 6, 2024

@PureWhiteWu PureWhiteWu added A-volo-build This issue concerns the `volo-build` crate. A-volo-thrift The issue concerns the `volo-thrift` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead. labels Nov 6, 2024
@PureWhiteWu PureWhiteWu self-assigned this Nov 6, 2024
@PureWhiteWu PureWhiteWu requested review from a team as code owners November 6, 2024 13:34
@PureWhiteWu PureWhiteWu merged commit 5d85c3d into main Nov 6, 2024
@PureWhiteWu PureWhiteWu deleted the fix/issue_515 branch November 6, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Ggiggle Ggiggle Ggiggle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PureWhiteWu PureWhiteWu

Labels

A-volo-build This issue concerns the `volo-build` crate. A-volo-thrift The issue concerns the `volo-thrift` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thrift bool parameter gets into unknown volo_genbool type, methods started with '_' losts underscore symbol

2 participants

@PureWhiteWu @Ggiggle