chore(volo-http): combine C/S Request and C/S Response types#534
Merged
yukiiiteru merged 1 commit intocloudwego:mainfrom Nov 16, 2024
Merged
chore(volo-http): combine C/S Request and C/S Response types#534yukiiiteru merged 1 commit intocloudwego:mainfrom
yukiiiteru merged 1 commit intocloudwego:mainfrom
Conversation
Since `Body` types of client and server have been combined, this commit combine `ClientRequest` and `ServerResquest` to `Request`, `ClientResponse` and `ServerResponse` to `Response`. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
PureWhiteWu
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since
Bodytypes of client and server have been combined, there is no need to split request/response intoClientXXXandServerXXX.Solution
Combine
ClientRequestandServerResquesttoRequest,ClientResponseandServerResponsetoResponse.To avoid too many breaking changes, the original types have not been removed but are marked as deprecated.