fix(volo-http): add mime parsing in server, do not always prefer ipv4 in client dns#538
Merged
yukiiiteru merged 4 commits intocloudwego:mainfrom Nov 28, 2024
Merged
Conversation
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
In the previous implementation, the `Form` extractor directly compared `Content-Type` and rejected the form if `Content-Type` was not `application/x-www-form-urlencoded`. But sometimes `Content-Type` could be `application/x-www-form-urlencoded; charset=utf-8`, which is actually a valid mime for the form, but we incorrectly rejected it. This commit makes the current implementation check `Content-Type` by parsing instead of directly comparing the string. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
We use the `hickory_resolver` crate to resolve domain names, but we found that it always prefers IPv4 addresses, which doesn't work if the client is running in an IPv6 only environment. This commit fixes this by checking the first name server, if the address is an IPv4 address we keep preferring IPv4 addresses, if it is an IPv6 address we set the resolver to prefer IPv6 addresses. Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
Signed-off-by: Yu Li <liyu.yukiteru@bytedance.com>
PureWhiteWu
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes two bugs
Formextractor reject mime of form with charsetIn the previous implementation, the
Formextractor directly comparedContent-Typeand rejected the form ifContent-Typewas notapplication/x-www-form-urlencoded.But sometimes
Content-Typecould beapplication/x-www-form-urlencoded; charset=utf-8, which is actually a valid mime for the form, but we incorrectly rejected it.DNS resolver always prefer IPv4 addresses
We use the
hickory_resolvercrate to resolve domain names, but we found that it always prefers IPv4 addresses, which doesn't work if the client is running in an IPv6 only environment.Solution
Content-Typeby parsing instead of directly comparing the string.In addition, we bump Volo-HTTP to 0.3.0 here.