Split grpc generated files into several files#540
Merged
Millione merged 17 commits intocloudwego:mainfrom Dec 3, 2024
Merged
Conversation
Contributor
Author
|
@Millione I added a simple grpc test, probably a more sophisticated one is required? If so, please feel free to add one, I'm not really faimilar with the grpc to create a proper test here |
Member
|
@missingdays Great, I think the grpc test for now is ok and there's only some ci problem to fix. |
Contributor
Author
|
Don't know why running |
Member
|
Maybe you should use nightly for it |
Millione
force-pushed
the
feature/better-grpc-split
branch
from
39b7d96 to
3c3f7db
Compare
Millione
reviewed
Dec 2, 2024
…feature/better-grpc-split # Conflicts: # tests/code-generation-workspace-split-grpc/.gitignore # tests/code-generation-workspace-split-grpc/Cargo.toml # tests/code-generation-workspace-split-grpc/volo.workspace.yml
Millione
approved these changes
Dec 3, 2024
Member
Millione
left a comment
Millione
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement grpc part of splitting the generated files started in this merge request - #510